Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(be): merge client problem repository into service #2198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnseok
Copy link
Contributor

@mnseok mnseok commented Nov 12, 2024

Description

  • client problem 모듈의 prisma 호출 부분이 repository로 분리되어있는 것을 합쳤습니다.
  • dto에서 class-validator를 사용하여 response를 filtering 하던 것을 service 내에서 처리해서 올바른 type으로 return하도록 수정하였습니다.

Additional context

  • 리뷰 후에 고칠 때 보려고 아직 이전 버전 코드들 주석처리만 해뒀습니다

Before submitting the PR, please make sure you do the following

@mnseok mnseok requested a review from Jaehyeon1020 November 12, 2024 05:53
@mnseok mnseok self-assigned this Nov 12, 2024
@coolify-skkuding
Copy link

coolify-skkuding bot commented Nov 12, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-11-12 05:55:49 CET

Copy link
Member

@Jaehyeon1020 Jaehyeon1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict 해결해주시면 리뷰할게요~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants