fix(fe): problem cannot be null (#1968)

* fix(fe): visible can be null * fix(fe): fix isvisible to be null if undefined
skkuding · Aug 18, 2024 · 71ebc00 · 71ebc00
1 parent 91b4e0a
commit 71ebc00
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/apps/frontend/app/admin/problem/_components/Columns.tsx b/apps/frontend/app/admin/problem/_components/Columns.tsx
@@ -20,7 +20,7 @@ interface DataTableProblem {
   difficulty: string
   submissionCount: number
   acceptedRate: number
-  isVisible: boolean
+  isVisible: boolean | null
   languages: string[]
   tag: { id: number; tag: Tag }[]
 }
@@ -33,7 +33,8 @@ function VisibleCell({ row }: { row: Row<DataTableProblem> }) {
       <Switch
         id="hidden-mode"
         onClick={(e) => e.stopPropagation()}
-        checked={row.original.isVisible}
+        disabled={!row.original.isVisible}
+        checked={row.original.isVisible === true}
         onCheckedChange={() => {
           row.original.isVisible = !row.original.isVisible
           updateVisible({
@@ -48,6 +49,7 @@ function VisibleCell({ row }: { row: Row<DataTableProblem> }) {
         }}
       />
       {!row.original.isVisible && (
+        // TODO: Add contest info modal
         <button
           className="justify-centert flex items-center"
           onClick={(e) => e.stopPropagation()}

diff --git a/apps/frontend/app/admin/problem/page.tsx b/apps/frontend/app/admin/problem/page.tsx
@@ -57,6 +57,7 @@ export default function Page({
     data?.getProblems.map((problem) => ({
       ...problem,
       id: Number(problem.id),
+      isVisible: problem.isVisible !== undefined ? problem.isVisible : null,
       languages: problem.languages ?? [],
       tag: problem.tag.map(({ id, tag }) => ({
         id: +id,

diff --git a/apps/frontend/app/admin/problem/utils.ts b/apps/frontend/app/admin/problem/utils.ts
@@ -3,7 +3,7 @@ import { z } from 'zod'
 
 const commonSchema = z.object({
   title: z.string().min(1, { message: 'required' }).max(200),
-  isVisible: z.boolean(),
+  isVisible: z.boolean().optional(),
   difficulty: z.enum(levels),
   languages: z.array(z.enum(languages)).min(1),
   description: z