Skip to content

Commit

Permalink
fix(cd): hide minio's id and password (#1952)
Browse files Browse the repository at this point in the history
기존에는 minIO의 ID와 PW가 파일에 노출되어 있었다.
Github Actions의 secrets를 사용해 해당 값을 환경 변수로 설정해 주어 사용함으로써 노출을 피할 수 있다.
  • Loading branch information
beeheavens authored Aug 15, 2024
1 parent 5815306 commit 4e2c669
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ services:
- 9001:9001
command: server /data --console-address ":9001"
environment:
MINIO_ROOT_USER: skku
MINIO_ROOT_PASSWORD: skku1234
MINIO_ROOT_USER: ${MINIO_ROOT_USER}
MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
volumes:
- codedang-storage:/data

Expand Down

0 comments on commit 4e2c669

Please sign in to comment.