Skip to content

Commit

Permalink
pythongh-122546: use same filename for different exceptions in new re…
Browse files Browse the repository at this point in the history
…pl (python#123217)

* pythongh-122546: use same filename for different exceptions in new repl

* +1
  • Loading branch information
skirpichev authored Aug 22, 2024
1 parent 427b106 commit 3d7b1a5
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
2 changes: 1 addition & 1 deletion Lib/_pyrepl/console.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def __init__(
self.can_colorize = _colorize.can_colorize()

def showsyntaxerror(self, filename=None, **kwargs):
super().showsyntaxerror(**kwargs)
super().showsyntaxerror(filename=filename, **kwargs)

def _excepthook(self, typ, value, tb):
import traceback
Expand Down
10 changes: 1 addition & 9 deletions Lib/code.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,7 @@ def showsyntaxerror(self, filename=None, **kwargs):
try:
typ, value, tb = sys.exc_info()
if filename and typ is SyntaxError:
# Work hard to stuff the correct filename in the exception
try:
msg, (dummy_filename, lineno, offset, line) = value.args
except ValueError:
# Not the format we expect; leave it alone
pass
else:
# Stuff in the right filename
value = SyntaxError(msg, (filename, lineno, offset, line))
value.filename = filename
source = kwargs.pop('source', "")
self._showtraceback(typ, value, None, source)
finally:
Expand Down
10 changes: 10 additions & 0 deletions Lib/test/test_pyrepl/test_pyrepl.py
Original file line number Diff line number Diff line change
Expand Up @@ -1100,6 +1100,16 @@ def test_not_wiping_history_file(self):
self.assertIn("spam", output)
self.assertNotEqual(pathlib.Path(hfile.name).stat().st_size, 0)

@force_not_colorized
def test_correct_filename_in_syntaxerrors(self):
env = os.environ.copy()
commands = "a b c\nexit()\n"
output, exit_code = self.run_repl(commands, env=env)
if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")
self.assertIn("SyntaxError: invalid syntax", output)
self.assertIn("<python-input-0>", output)

@force_not_colorized
def test_proper_tracebacklimit(self):
env = os.environ.copy()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Consistently use same file name for different exceptions in the new repl.
Patch by Sergey B Kirpichev.

0 comments on commit 3d7b1a5

Please sign in to comment.