Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport cherry picks to release/v1.x.x #805

Merged
merged 15 commits into from
Nov 12, 2024

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Oct 24, 2024

Closes CON-1859
Closes CON-1858

PRs to backport:
66aac54
Checking if a normalize by pair is enabled in the MM (this will be used when the sidecar calls (Validate)
efff2b1
Unsiwap fix
f4be9c5
No longer check last-updated
422229b
testing improvement

c5b2cfc
websocket provider perf fix

also removed the spell check gh workflow

@skip-mev skip-mev deleted a comment from github-actions bot Oct 24, 2024

This comment has been minimized.

@aljo242 aljo242 changed the title chore: backport cherry picks chore: backport cherry picks to release/v1.x.x Oct 24, 2024
@aljo242
Copy link
Contributor Author

aljo242 commented Oct 24, 2024

ignore the spell check errors - we deleted this check in our main, so I'm deleting it here

@skip-mev skip-mev deleted a comment from github-actions bot Oct 24, 2024

This comment has been minimized.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 30.03802% with 184 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.x.x@ef03f40). Learn more about missing BASE report.

Files with missing lines Patch % Lines
providers/providertest/provider.go 0.00% 111 Missing ⚠️
providers/providertest/util.go 0.00% 54 Missing ⚠️
oracle/market_mapper.go 81.25% 4 Missing and 2 partials ⚠️
cmd/slinky/main.go 78.26% 5 Missing ⚠️
providers/apis/defi/ethmulticlient/client.go 0.00% 4 Missing ⚠️
providers/apis/defi/raydium/client.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/v1.x.x     #805   +/-   ##
=================================================
  Coverage                  ?   57.55%           
=================================================
  Files                     ?      259           
  Lines                     ?    17005           
  Branches                  ?        0           
=================================================
  Hits                      ?     9788           
  Misses                    ?     6483           
  Partials                  ?      734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

@zrbecker
Copy link
Member

zrbecker commented Nov 5, 2024

Can we cherry-pick the CODEOWNERS file too

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Nov 7, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (10)

cae
connecttypes
dafa
ddb
fcff
goautoneg
minprovider
morikuni
munnerz
providertest

These words are not needed and should be removed aljo monkeyc sauron technicallyty tsql Warehime wesl

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:skip-mev/connect.git repository
on the backport/cherry-picks branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/skip-mev/connect/actions/runs/11730137582/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (956) from .github/actions/spelling/expect.txt and unrecognized words (10)

Dictionary Entries Covers Uniquely
cspell:python/src/python/python-lib.txt 2417 11 5
cspell:fullstack/dict/fullstack.txt 419 6 5
cspell:java/src/java.txt 2464 6 4
cspell:filetypes/filetypes.txt 264 4 3
cspell:shell/dict/shell-all-words.txt 113 3 3

Consider adding them (in .github/workflows/spell.yml) in jobs:/build: to extra_dictionaries:

          cspell:python/src/python/python-lib.txt
          cspell:fullstack/dict/fullstack.txt
          cspell:java/src/java.txt
          cspell:filetypes/filetypes.txt
          cspell:shell/dict/shell-all-words.txt

To stop checking additional dictionaries, add (in .github/workflows/spell.yml):

check_extra_dictionaries: ''
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

⚠️ Warnings Count
⚠️ no-newline-at-eof 4

See ⚠️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

🚂 If you're seeing this message and your PR is from a branch that doesn't have check-spelling,
please merge to your PR's base branch to get the version configured for your repository.

@aljo242 aljo242 merged commit 8e11746 into release/v1.x.x Nov 12, 2024
7 of 8 checks passed
@aljo242 aljo242 deleted the backport/cherry-picks branch November 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants