-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport cherry picks to release/v1.x.x
#805
Conversation
This comment has been minimized.
This comment has been minimized.
release/v1.x.x
ignore the spell check errors - we deleted this check in our |
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.x.x #805 +/- ##
=================================================
Coverage ? 57.55%
=================================================
Files ? 259
Lines ? 17005
Branches ? 0
=================================================
Hits ? 9788
Misses ? 6483
Partials ? 734 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Can we cherry-pick the CODEOWNERS file too |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (10)cae These words are not needed and should be removedaljo monkeyc sauron technicallyty tsql Warehime weslTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:skip-mev/connect.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/skip-mev/connect/actions/runs/11730137582/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (956) from .github/actions/spelling/expect.txt and unrecognized words (10)
Consider adding them (in cspell:python/src/python/python-lib.txt
cspell:fullstack/dict/fullstack.txt
cspell:java/src/java.txt
cspell:filetypes/filetypes.txt
cspell:shell/dict/shell-all-words.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See If the flagged items are 🤯 false positivesIf items relate to a ...
🚂 If you're seeing this message and your PR is from a branch that doesn't have check-spelling, |
Closes CON-1859
Closes CON-1858
PRs to backport:
66aac54
Checking if a normalize by pair is enabled in the MM (this will be used when the sidecar calls (Validate)
efff2b1
Unsiwap fix
f4be9c5
No longer check last-updated
422229b
testing improvement
c5b2cfc
websocket provider perf fix
also removed the spell check gh workflow