nicoll/include balance transactions for reports #1761
Conversation
nicollguarnizo
commented
Oct 23, 2024
•
nicollguarnizo
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| datalabels: { | ||
| formatter: function (value: any) { |
There was a problem hiding this comment.
I'm struggling to make this loads! It seems to be a bug in quickchart, for now it displays as a number format and no the currency
https://chartjs-plugin-datalabels.netlify.app/guide/formatting.html#data-transformation
| const combinedTransactions = balanceTransactionsResult.transactions.map( | ||
| (transaction): CombinedBalanceTransaction => { | ||
| if ( | ||
| (transaction.type === 'charge' || transaction.type === 'payment') && |
There was a problem hiding this comment.
stripe added some methods of payments besides credit card, such as 'klarna' and it treats them as payment and not a charge - same with the refunds for those, so we need to add that type here.
| } from 'lib/transactions' | ||
| import {prisma} from '@skillrecordings/database' | ||
| import {calculateTotals} from 'components/calculations/calculate-totals' | ||
| import {calculateSplits} from 'components/calculations/calculate-splits' | ||
|
|
||
| const ANNOUNCE_CHANNEL = 'C07RDAMQ7PG' | ||
| const ANNOUNCE_CHANNEL = 'C03QFFWHT7D' |
There was a problem hiding this comment.
we will get the whole monthly report in lc-epic-web for us - it's exactly the same as our complicated spread sheet (before expenses)
| const chartData = { | ||
| type: 'doughnut', | ||
| type: 'bar', |
There was a problem hiding this comment.
I had to change the type of graph - a pie chart was not UX friendly when there are so many products and specially when Epic React has such an advantage over the other products, it wasn't legible. I used some min length in this type and it looks better
|
|
||
| type ProductGroup = { | ||
| export type ProductGroup = { |
There was a problem hiding this comment.
it might make sense to move these types up, maybe there's a "lib" here so we have an "sdk" for report building logic?
| groups[product].fee += charge.fee | ||
| return groups | ||
| }, {} as Record<string, ProductGroup>) | ||
|
|
||
| // Add products that only have refunds to the productGroups | ||
| // Apply refunds to product groups |
There was a problem hiding this comment.
comment like this might suggest this could be a nice named function
