fix: let them skip the essay

skillrecordings · Oct 28, 2024 · 1c111d6 · 1c111d6
1 parent e1cd0b1
commit 1c111d6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/apps/total-typescript/src/offer/survey/data-typescript-2024.ts b/apps/total-typescript/src/offer/survey/data-typescript-2024.ts
@@ -227,6 +227,7 @@ export const dataTypescript2024: QuizResource = {
     },
     final_story: {
       question: getFinalQuestion,
+      required: false,
       type: 'essay',
     },
   },

diff --git a/apps/total-typescript/src/offer/survey/survey-question.tsx b/apps/total-typescript/src/offer/survey/survey-question.tsx
@@ -87,9 +87,11 @@ const SurveyQuestion = React.forwardRef(function Question(
                 .label('Options')
                 .nullable()
             : Yup.string().required('Pick an option.').nullable()
-          : Yup.string()
+          : props.currentQuestion.required
+          ? Yup.string()
               .nullable()
-              .required(`Can't stay empty. Mind to elaborate? :)`),
+              .required(`Can't stay empty. Please elaborate!`)
+          : Yup.string().nullable(),
     }),
     onSubmit: async (values) => {
       console.log('formik on submit', values)

diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -111,6 +111,7 @@ export type QuestionResource = {
   template?: string
   shuffleChoices?: boolean
   allowMultiple?: boolean
+  required?: boolean
   code?: {
     filename: string
     active: boolean