Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@haydn Closes #150.
What I've done
I've done everything mentioned on #150 except for the last one, which says
The reason I've left this out is because I'm not entirely sure what this means (or what it's for). It also isn't in sync with the protocol specific in #149. Maybe you can clarify this a bit in this PR?
Some other notes:
request
property to the protocol messages.removeEventListener
on line 26 ofuseCanvasConnection.js
because according to the protocol, thesketchbook_response:acknowledge
response should listen more than once forsketchbook_request:ping
requests (in case of canvas disconnection, for example).useCanvasConnection.js
, I've used a different id to avoid any confusion between the ids even though they can technically be the same since they're unrelated.