Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/request response #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ref/request response #155

wants to merge 2 commits into from

Conversation

Mxchaeltrxn
Copy link
Member

@Mxchaeltrxn Mxchaeltrxn commented Sep 15, 2021

@haydn Closes #150.

What I've done

I've done everything mentioned on #150 except for the last one, which says

Update the sketchbook_response:measure request to have a layer field

The reason I've left this out is because I'm not entirely sure what this means (or what it's for). It also isn't in sync with the protocol specific in #149. Maybe you can clarify this a bit in this PR?

Some other notes:

  • I've also added the request property to the protocol messages.
  • I've removed the removeEventListener on line 26 of useCanvasConnection.js because according to the protocol, the sketchbook_response:acknowledge response should listen more than once for sketchbook_request:ping requests (in case of canvas disconnection, for example).
  • On line 87 and 89 of useCanvasConnection.js, I've used a different id to avoid any confusion between the ids even though they can technically be the same since they're unrelated.

@vercel
Copy link

vercel bot commented Sep 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sketchbook-js/sketchbook/4rG1FxdqnfxLkma2hfumq1rsz7hn
✅ Preview: https://sketchbook-git-ref-requestresponse-sketchbook-js.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update protocol messages to match v1 architecture
1 participant