Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ProgressRing show label on demand #2996

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

phamduylong
Copy link
Contributor

@phamduylong phamduylong commented Nov 22, 2024

Linked Issue

Closes #2992

Description

Made label show only on demand

TODO: update site examples and generate changesets

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: a5c8f78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skeletonlabs/skeleton-svelte Patch
@skeletonlabs/skeleton-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Nov 22, 2024 9:14pm

Copy link
Contributor

@endigo9740 endigo9740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Long. If you could make these couple minor changes and supply the documentation updates requested, then this should be good to go.

@phamduylong
Copy link
Contributor Author

Looks great Long. If you could make these couple minor changes and supply the documentation updates requested, then this should be good to go.

Yeah it's not finished yet, there's no draft flag on PR in GitHub it seems. I'll probably get it done soon enough when I figure out how to update site examples and refactor the stuff you pointed out. Thanks for the review.

@endigo9740
Copy link
Contributor

endigo9740 commented Nov 22, 2024

There's an option when creating PRs to mark it as a draft, otherwise they have a super tiny option on the sidebar near where you assign reviewers. Not sure why it's not more obvious, but it is there! :)

Screenshot 2024-11-22 at 9 41 45 AM

@endigo9740 endigo9740 marked this pull request as draft November 22, 2024 20:36
@phamduylong
Copy link
Contributor Author

phamduylong commented Nov 22, 2024

@endigo9740 probably could be permission issues that caused this :D I don't have the option. Could you un-draft this and give this another review?
image

Edit: NVM I can un-draft it. This is ready nonetheless

@phamduylong phamduylong marked this pull request as ready for review November 22, 2024 21:17
@phamduylong phamduylong changed the title WIP: Made progress ring show label on demand Made ProgressRing show label on demand Nov 22, 2024

<div class="grid grid-cols-1 gap-4 justify-center">
<ProgressRing {value} {max} showLabel />
<input type="range" class="input max-w-32" bind:value {max} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we go ahead and drop the range input for the label example. The focus should be the label itself. The first demo already shows you can bind the and manipulate the state like this.

Less code = easier for folks to digest!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phamduylong if you can implement this change I think we're good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants