Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try vite #72

Merged
merged 13 commits into from
Oct 13, 2023
Merged

try vite #72

merged 13 commits into from
Oct 13, 2023

Conversation

fakefeik
Copy link
Contributor

@fakefeik fakefeik commented Jan 8, 2023

No description provided.

@fakefeik fakefeik force-pushed the try-vite branch 7 times, most recently from b26016b to 4c49e5b Compare January 8, 2023 15:51
@fakefeik fakefeik changed the title wip try vite Jan 8, 2023
@fakefeik fakefeik force-pushed the try-vite branch 18 times, most recently from 0f5e286 to 2b28d04 Compare May 1, 2023 17:23
@semkedaniil semkedaniil force-pushed the try-vite branch 2 times, most recently from d1cdb9d to 21fac17 Compare October 5, 2023 12:22
@semkedaniil semkedaniil force-pushed the try-vite branch 3 times, most recently from 893e66d to b996c77 Compare October 9, 2023 18:34
@semkedaniil
Copy link
Contributor

semkedaniil commented Oct 10, 2023 •
edited
Loading

@fakefeik, можешь посмотреть?
Я перевел на vite, обновил yarn до 3 версии, все починил, поднял js'ные тесты.

fakefeik
fakefeik commented Oct 12, 2023
View reviewed changes
Copy link
Contributor Author

@fakefeik fakefeik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

посмотрел, оч круто, осталось несколько вопросов

.github/workflows/actions.yml Outdated Show resolved Hide resolved
db-viewer-ui/package.json Outdated Show resolved Hide resolved
db-viewer-ui/package.json Show resolved Hide resolved
db-viewer-ui/src/Components/ObjectViewer/ObjectKeys.tsx Show resolved Hide resolved
db-viewer-ui/src/Domain/Utils/ConvertTimeUtil.tsx Show resolved Hide resolved
db-viewer-ui/stories/AdminTools/ObjectEditableCustomRender.stories.tsx Show resolved Hide resolved
db-viewer-ui/vite.config.ts Show resolved Hide resolved
fakefeik
fakefeik commented Oct 12, 2023
View reviewed changes
db-viewer-ui/package.json Outdated Show resolved Hide resolved
fakefeik
fakefeik commented Oct 12, 2023
View reviewed changes
db-viewer-ui/tsconfig.json Outdated Show resolved Hide resolved
fakefeik
fakefeik commented Oct 12, 2023
View reviewed changes
db-viewer-ui/tsconfig.json Outdated Show resolved Hide resolved
@fakefeik
Copy link
Contributor Author

👍

@semkedaniil semkedaniil merged commit 7e5f6c7 into master Oct 13, 2023
2 checks passed
@fakefeik
Copy link
Contributor Author

на будущее: надо тег v1.6-release было писать, чтобы в гитхабе тоже релиз создался

@fakefeik fakefeik deleted the try-vite branch October 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semkedaniil semkedaniil semkedaniil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fakefeik @semkedaniil