Bump solhint from 3.4.1 to 4.5.4 #2589
Annotations
1 error and 13 warnings
Lint:
contracts/Marionette.sol#L72
Function order is incorrect, constructor/initializer can not go after receive function (line 68)
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions/setup-node@v2, actions/setup-python@v2, codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v2, actions/setup-python@v2, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Lint:
contracts/interfaces/IMarionette.sol#L24
global import of path @skalenetwork/ima-interfaces/IMessageReceiver.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
Lint:
contracts/interfaces/IMarionette.sol#L29
Function initialize() must match Foundry test naming convention
|
Lint:
contracts/interfaces/IMarionette.sol#L30
Function execute() must match Foundry test naming convention
|
Lint:
contracts/interfaces/IMarionette.sol#L30
GC: Named return value is missing - Index 0
|
Lint:
contracts/interfaces/IMarionette.sol#L30
Rule is set with explicit type [var/s: uint]
|
Lint:
contracts/interfaces/IMarionette.sol#L31
Function setVersion() must match Foundry test naming convention
|
Lint:
contracts/interfaces/IMarionette.sol#L32
Function sendSFuel() must match Foundry test naming convention
|
Lint:
contracts/interfaces/IMarionette.sol#L32
Rule is set with explicit type [var/s: uint]
|
Lint:
contracts/interfaces/IMarionette.sol#L33
Function encodeFunctionCall() must match Foundry test naming convention
|
Lint:
contracts/interfaces/IMarionette.sol#L33
GC: Named return value is missing - Index 0
|
Get yarn cache directory path
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading