Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receiver field for S-S and M->S only #1265

Closed
payvint opened this issue Sep 2, 2022 · 2 comments · Fixed by #1389 or skalenetwork/ima-interfaces#205 · May be fixed by #1297 or skalenetwork/ima-interfaces#171
Closed

Add receiver field for S-S and M->S only #1265

payvint opened this issue Sep 2, 2022 · 2 comments · Fixed by #1389 or skalenetwork/ima-interfaces#205 · May be fixed by #1297 or skalenetwork/ima-interfaces#171
Assignees
Labels
enhancement New feature or request IMA

Comments

@payvint
Copy link
Collaborator

payvint commented Sep 2, 2022

Problem:

During all type of transfer (M->S, S->M, S->S) we set a receiver as msg.sender. So you can not send funds to anyone except your own address.
Some time ago we found a vulnerability about draining CommunityPool wallets during S -> M messages and decided to remove receiver field everywhere.

But right now we understand that some customers want to transfer funds to different address (From hot/cold wallets or from MultiSig wallets).

We can add receiver fields in M -> S and S -> S transfer without providing any vulnerabilitity holes

@payvint payvint added enhancement New feature or request IMA labels Sep 2, 2022
@payvint payvint added this to the 2.1 milestone Sep 2, 2022
@payvint payvint self-assigned this Sep 2, 2022
@gannakulikova gannakulikova removed this from the 2.1 milestone Oct 3, 2022
@cstrangedk cstrangedk changed the title Add receiver field Add receiver field for S-S and M->S only Oct 7, 2022
@PolinaKiporenko
Copy link

only M->S part of 2.1 scope

@payvint
Copy link
Collaborator Author

payvint commented Dec 30, 2022

Add a subtask #1390 and additional PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment