Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receiver field mainnet part #1294

Closed
wants to merge 35 commits into from
Closed

Conversation

payvint
Copy link
Collaborator

@payvint payvint commented Oct 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1294 (45e7d8d) into develop (58493cd) will increase coverage by 3.48%.
The diff coverage is 89.17%.

❗ Current head 45e7d8d differs from pull request most recent head a4bfe3e. Consider uploading reports for the commit a4bfe3e to get more accurate results

@@             Coverage Diff             @@
##           develop    #1294      +/-   ##
===========================================
+ Coverage    85.95%   89.44%   +3.48%     
===========================================
  Files           26       26              
  Lines         1182     1307     +125     
  Branches       320      351      +31     
===========================================
+ Hits          1016     1169     +153     
+ Misses          68       37      -31     
- Partials        98      101       +3     
Impacted Files Coverage Δ
proxy/contracts/Messages.sol 74.19% <ø> (ø)
proxy/contracts/mainnet/DepositBox.sol 93.33% <ø> (ø)
...nnet/DepositBoxes/DepositBoxERC721WithMetadata.sol 100.00% <ø> (ø)
proxy/contracts/mainnet/Linker.sol 87.50% <ø> (ø)
proxy/contracts/schain/MessageProxyForSchain.sol 75.47% <ø> (+6.50%) ⬆️
proxy/contracts/schain/TokenManager.sol 87.80% <ø> (ø)
proxy/contracts/schain/TokenManagerLinker.sol 94.59% <ø> (ø)
...n/TokenManagers/TokenManagerERC721WithMetadata.sol 95.23% <ø> (ø)
proxy/contracts/schain/tokens/ERC1155OnChain.sol 70.00% <ø> (ø)
proxy/contracts/schain/tokens/ERC20OnChain.sol 85.71% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@payvint payvint changed the title Feature/add receiver field Add receiver field mainnet part Oct 4, 2022
@payvint payvint linked an issue Oct 5, 2022 that may be closed by this pull request
@payvint
Copy link
Collaborator Author

payvint commented Dec 30, 2022

Closing because of #1390

@payvint payvint closed this Dec 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add receiver field for S-S and M->S only
2 participants