Update check url function in SNB #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrotkk
requested review from
sergiy-skalelabs and
DmytroNazarenko
as code owners
DmytroNazarenko
approved these changes
Feb 7, 2024
sergiy-skalelabs
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the check URL function in the SKALE network-browser to improve network provider compatibility.
In the previous version
fetchwith an empty body was used to check that mainnet and sChain endpoints were available, which failed for some providers (Infura for example). This PR fixes it usingprovider.getBlockNumberto determine if the endpoint is valid.No additional tests are needed, and no performance changes.
Fixes #85