Resolve promise on size limit 'error' #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
SizeLimitExceededError(aka the "expected" result for setting a limit on number of results) would cause the Promise to be rejected. This PR adds a check on whether the search had a sizeLimit and if it did, then take the error as a signal to say "I'm done" and resolve instead. For downstream code, I added ahitSizeLimitflag on the result so it's possible to still resolve the Promise but still know whether the result set was caused by hitting the limit.Looking at the list of errors (http://ldapjs.org/errors.html), this seems to be the only "error" that is actually a signal to success.