Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 do not remove self parameter annotation when types do not match #195

Merged
merged 4 commits into from
Nov 24, 2023
Merged

fix: 🐛 do not remove self parameter annotation when types do not match #195

merged 4 commits into from
Nov 24, 2023

Commits on Nov 24, 2023

  1. fix: 🐛 do not remove self parameter annotation when types do not match 

    always removing the first parameter's type annotation when it is named self masked an underlying issue in the C++ binding, which is revealed when you only remove the parameter's annotation when it matches the class name it is bound to or it is typing.Any
    @ringohoffman
    ringohoffman committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    d29dc2c View commit details
    Browse the repository at this point in the history

  2. refactor: ♻️ clean up condition 

    sizmailov#195 (comment)
    @ringohoffman
    ringohoffman committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7d5b739 View commit details
    Browse the repository at this point in the history

  3. test: ✅ add new test missing_self_arg inspired by the bug in foreign_… 

    …method_arg

sizmailov#195
    @ringohoffman
    ringohoffman committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    292f88c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-replacing-self-arg-annotation-when-typ… 

    …e-mismatch
    @sizmailov
    sizmailov authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    bfd275d View commit details
    Browse the repository at this point in the history