Fix watt-to-ftp-calculation rounding issues #414
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inputing watts in the editor, the resulting watts in the workout can differ by 1, because of flooring/rounding issues. This is fixed by rounding the wattFromFtpPct-calculation instead of flooring
Example
FTP: 280, input 279
ftpPct = Math.floor(1000 * (279 / 280)) / 10;
ftPct = 99.6
result in editor: 279, 99.6%
when we then calculate in the workout:
Math.floor((ftpPct * ftp) / 100) = Math.floor((27888 / 100) = 278;
Based on my tests, changing the floor in the
wattFromFtpPct
to round, should fix this.Since
Gif of error in action : 279 => 278
Testing
Testing code old version
=> Lots of issues
Testing code for new version
=> All watts are correct