Change power controls to adjust FTP , not only current interval ⚡ #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change power controls to adjust FTP
This fixes #239
Also fixes/adds the feature in #240
Why
Personally, most of the time i want my adjustments to affect the whole workout,
and not having to change every single interval (and then having to wait for the start of the intervals).
When changing the whole workout, i think the easiest, both coding and conceptually for the users, is to change the workout ftp.
How it works currently
In a workout with
During int1, changing +10% (20W), will result int
How it works after this PR
In a workout with ftp=200, changing +10% during any interval, means ftp=220, and all intervals will be adjusted.
As can be seen in the gifs
In a workout with
During int1, changing +10% (20W), will result int
Set from buttons:
Set from input:
Considerations
Depends on how you look at your workout, this may be a bit more confusing.
At least, if your main point is just to increase the interval at 70% from 200 -> 220W, that means you have to either calculate the FTP where FTP*70%=220 or just click and see.
Should the power controls be % based at all?
Related to the point above. I think one would probably more often increase by a set number (1,5,10W), instead of %.
Instead of changing everything to FTP instead of interval, maybe this should be a switch/flip in the power control gui , where you decide what you want. Should be pretty easy
Maybe these FTP-based power controls should be included in the workout controls?
And the interval-ones, be kept in the power controls? Kinda best of both worlds, functionality wise at least
Should also add the possibility to actually change a workout during a session. This would maybe get rid of the need of the need of these adjust ftp-buttons, when you can adjust it inside the workout editor. But these buttons are more convenient still