Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change power controls to adjust FTP , not only current interval ⚡ #243

Closed
wants to merge 3 commits into from

Conversation

morteako
Copy link
Collaborator

Change power controls to adjust FTP

This fixes #239
Also fixes/adds the feature in #240

Why

Personally, most of the time i want my adjustments to affect the whole workout,
and not having to change every single interval (and then having to wait for the start of the intervals).
When changing the whole workout, i think the easiest, both coding and conceptually for the users, is to change the workout ftp.

How it works currently

In a workout with

ftp=200W
int1 : 70% - 140W
int2 : 80% - 160W

During int1, changing +10% (20W), will result int

ftp=200W
int1 : 70% - 160W
int2 : 80% - 160W

How it works after this PR

In a workout with ftp=200, changing +10% during any interval, means ftp=220, and all intervals will be adjusted.
As can be seen in the gifs

In a workout with

ftp=200W
int1 : 70% - 140W
int2 : 80% - 160W

During int1, changing +10% (20W), will result int

ftp=220W
int1 : 70% - 154W
int2 : 80% - 176W

Set from buttons:
2023-10-14 12 28 42

Set from input:
2023-10-14 12 33 07

Considerations

  • Depends on how you look at your workout, this may be a bit more confusing.
    At least, if your main point is just to increase the interval at 70% from 200 -> 220W, that means you have to either calculate the FTP where FTP*70%=220 or just click and see.

  • Should the power controls be % based at all?
    Related to the point above. I think one would probably more often increase by a set number (1,5,10W), instead of %.

  • Instead of changing everything to FTP instead of interval, maybe this should be a switch/flip in the power control gui , where you decide what you want. Should be pretty easy

  • Maybe these FTP-based power controls should be included in the workout controls?
    And the interval-ones, be kept in the power controls? Kinda best of both worlds, functionality wise at least

  • Should also add the possibility to actually change a workout during a session. This would maybe get rid of the need of the need of these adjust ftp-buttons, when you can adjust it inside the workout editor. But these buttons are more convenient still

@morteako
Copy link
Collaborator Author

:)

@morteako morteako closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power Control - doesnt update target watt display
1 participant