Use Proxy config when available #124
Open
+21
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables you to use sign.js behind a WebProxy, which is sadly necessary in many "Enterprise" environments. This will automatically use the ENV variable HTTPS_PROXY that is standard for e.g. Curl and other unix utils. This should be compatible with MacOS, Linux and Windows environments with a posix like shell.
I have not tested this with a Authorization header against the Sitevision sign server, nor against the proxy. There is not support for proxy Authentication AFAIK at this time.
sign.js is impossible to use behind a WebProxy unless this is merged.
There are many things that could be improved upon here, e.g. doing a liveness check against the signing server, checking for errors that the proxy might introduce, or just making the client responsible for the signing. These are not in scope of this PR.