Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: append uniq validator for name field of content-type #40

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/server/src/app/contact-type/dto/contact-type.dto.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
import { ApiProperty } from "@nestjs/swagger";
import { contact_types } from "@prisma/client";
import { IsNotEmpty } from "class-validator";
import { IsAlreadyExist } from "../../shared/validators/is-already-exist";
export class ContactTypeDto implements Omit<contact_types, "id"> {
@ApiProperty()
@IsNotEmpty()
@IsAlreadyExist(
{ entity: "contact_types", field: "name" },
{
message: ({ value, property }) =>
`field ${property} with ${value} is found`,
}
)
name!: string;

@ApiProperty()
Expand Down
7 changes: 7 additions & 0 deletions apps/server/src/app/database/db.interface.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export interface DbInterface {
isAlreadyExist(
value: unknown,
entity: string,
field: string
): Promise<boolean>;
}
26 changes: 26 additions & 0 deletions apps/server/src/app/database/db.service.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { DbInterface } from "./db.interface";
import { Service } from "typedi";
import { PrismaClientService } from "@site15/prisma/server";

@Service()
export class DbService implements DbInterface {
static instance: DbInterface;
private readonly prismaClintService: PrismaClientService;
constructor() {
DbService.instance = this;
this.prismaClintService = PrismaClientService.instance;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

короче убери призму, не нужно делать универсальный способ, у тя по задаче идет конкретная логика для нее сделай

прикол с докидыванием реализации для работы с базой возьми тут https://github.com/EndyKaufman/kaufman-bot/blob/develop/libs/bot-in-groups/server/src/lib/bot-in-groups-config/bot-in-groups.config.ts

тайп ди выпиливай, я тебе как пример сказал что былобы круто его взять, но так как ты на неста идешь и тут мы решаем проблемы диай неста и модулей, то как бы тупо - брать левый диай, когда есть свой диай, кривой но есть

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для общего понимания диай, юзать тайп ди, да это круто, я увидел что ты можешь и ты сам понял как юзать диай вне неста) цель достигнута, можно выпиливать тайп ди и брать нест диай

}

async isAlreadyExist(
value: unknown,
entity: string,
field: string
): Promise<boolean> {
const data = await this.prismaClintService[entity].findFirst({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

убери универсальность, нужно четка по фиче

where: {
[field]: value,
},
});
return !!data;
}
}
52 changes: 52 additions & 0 deletions apps/server/src/app/shared/validators/is-already-exist.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вообще не нужно создать такой папки шаред, пуляй в папку фичи

registerDecorator,
ValidationArguments,
ValidationOptions,
ValidatorConstraint,
ValidatorConstraintInterface,
} from "class-validator";
import { PrismaClientService } from "@site15/prisma/server";
import { Container } from "typedi";
import { DbInterface } from "../../database/db.interface";
import { DbService } from "../../database/db.service";

interface Data {
entity: string;
field: string;
}

@ValidatorConstraint({ async: true })
class ExistsConstraint implements ValidatorConstraintInterface {
private dbService: DbInterface;
constructor() {
this.dbService = Container.get<DbInterface>(DbService);
}
async validate(
currentValue: unknown,
args?: ValidationArguments
): Promise<boolean> {
const entity = args?.constraints[0]?.entity;
const field = args?.constraints[0]?.field;
return !(await this.dbService.isAlreadyExist(currentValue, entity, field));
}

defaultMessage(validationArguments?: ValidationArguments): string {
const data = validationArguments?.constraints[0];
return `${data.entity} field ${validationArguments?.value} is found.`;
}
}

export function IsAlreadyExist(
data: Data,
validationOptions?: ValidationOptions
) {
// eslint-disable-next-line @typescript-eslint/ban-types
return (object: Object, propertyName: string) =>
registerDecorator({
target: object.constructor,
propertyName,
options: validationOptions,
constraints: [data],
validator: ExistsConstraint,
});
}
Loading