-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: append uniq validator for name field of content-type #40
Open
lastdoctor
wants to merge
1
commit into
develop
Choose a base branch
from
feature/36
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export interface DbInterface { | ||
isAlreadyExist( | ||
value: unknown, | ||
entity: string, | ||
field: string | ||
): Promise<boolean>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { DbInterface } from "./db.interface"; | ||
import { Service } from "typedi"; | ||
import { PrismaClientService } from "@site15/prisma/server"; | ||
|
||
@Service() | ||
export class DbService implements DbInterface { | ||
static instance: DbInterface; | ||
private readonly prismaClintService: PrismaClientService; | ||
constructor() { | ||
DbService.instance = this; | ||
this.prismaClintService = PrismaClientService.instance; | ||
} | ||
|
||
async isAlreadyExist( | ||
value: unknown, | ||
entity: string, | ||
field: string | ||
): Promise<boolean> { | ||
const data = await this.prismaClintService[entity].findFirst({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. убери универсальность, нужно четка по фиче |
||
where: { | ||
[field]: value, | ||
}, | ||
}); | ||
return !!data; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. вообще не нужно создать такой папки шаред, пуляй в папку фичи |
||
registerDecorator, | ||
ValidationArguments, | ||
ValidationOptions, | ||
ValidatorConstraint, | ||
ValidatorConstraintInterface, | ||
} from "class-validator"; | ||
import { PrismaClientService } from "@site15/prisma/server"; | ||
import { Container } from "typedi"; | ||
import { DbInterface } from "../../database/db.interface"; | ||
import { DbService } from "../../database/db.service"; | ||
|
||
interface Data { | ||
entity: string; | ||
field: string; | ||
} | ||
|
||
@ValidatorConstraint({ async: true }) | ||
class ExistsConstraint implements ValidatorConstraintInterface { | ||
private dbService: DbInterface; | ||
constructor() { | ||
this.dbService = Container.get<DbInterface>(DbService); | ||
} | ||
async validate( | ||
currentValue: unknown, | ||
args?: ValidationArguments | ||
): Promise<boolean> { | ||
const entity = args?.constraints[0]?.entity; | ||
const field = args?.constraints[0]?.field; | ||
return !(await this.dbService.isAlreadyExist(currentValue, entity, field)); | ||
} | ||
|
||
defaultMessage(validationArguments?: ValidationArguments): string { | ||
const data = validationArguments?.constraints[0]; | ||
return `${data.entity} field ${validationArguments?.value} is found.`; | ||
} | ||
} | ||
|
||
export function IsAlreadyExist( | ||
data: Data, | ||
validationOptions?: ValidationOptions | ||
) { | ||
// eslint-disable-next-line @typescript-eslint/ban-types | ||
return (object: Object, propertyName: string) => | ||
registerDecorator({ | ||
target: object.constructor, | ||
propertyName, | ||
options: validationOptions, | ||
constraints: [data], | ||
validator: ExistsConstraint, | ||
}); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
короче убери призму, не нужно делать универсальный способ, у тя по задаче идет конкретная логика для нее сделай
прикол с докидыванием реализации для работы с базой возьми тут https://github.com/EndyKaufman/kaufman-bot/blob/develop/libs/bot-in-groups/server/src/lib/bot-in-groups-config/bot-in-groups.config.ts
тайп ди выпиливай, я тебе как пример сказал что былобы круто его взять, но так как ты на неста идешь и тут мы решаем проблемы диай неста и модулей, то как бы тупо - брать левый диай, когда есть свой диай, кривой но есть
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
для общего понимания диай, юзать тайп ди, да это круто, я увидел что ты можешь и ты сам понял как юзать диай вне неста) цель достигнута, можно выпиливать тайп ди и брать нест диай