Add ability to set sequence number for cases where sequence number is not generated locally. #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not generated locally. For example webrtc media servers.
|
It seems as though this unit test is failing in the current master branch CheckDuplicateBindPortFailsUnitTest |
sipsorcery
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases that do not involve the media being generated locally it is requires that the sequence number be passed along correctly to client connections.
Currently Sipsorcery auto generates sequence numbers when SendRtpRaw is called.
An example of this is a WebRtc media server. If you mark sequential sequence numbers for packets that are not actually sequential it results in distortion on the client side. The client needs to be aware of packets that were lost on the way to the server.
I have added an additional implementation of SendRtpRaw that includes a sequence number. I have attempted to keep the existing methods the same as to not make breaking changes.
Thanks for all the hard work on this project!