Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new ring types #55

Open
wants to merge 2 commits into
base: release-16.04
Choose a base branch
from
Open

Adding new ring types #55

wants to merge 2 commits into from

Conversation

yozmag
Copy link

@yozmag yozmag commented May 9, 2016

Adding new Ring types according to yealink configuration parameters V80

Adding new Ring types according to yealink configuration parameters V80
@bmachens
Copy link
Collaborator

bmachens commented May 9, 2016

We already have "yealink_ring_type", so why we need to have a duplicate?

Adding Silent, Splash and Common to "yealink_ring_type" should be enough or not?

@yozmag
Copy link
Author

yozmag commented May 9, 2016

There is account.X.ringtone.ring_type and phone_setting.ring_type the difference between the two is the 'Common' that is only used in account.X.ringtone.ring_type. Looks better to have have two types. What is you idea about this issue.

@bmachens
Copy link
Collaborator

bmachens commented May 9, 2016

Yes, now i see the "Common" problem. Make sense to have these two types.
I toke a look at the Provisioning Guide and may we add Silent and Splash to "yealink_ring_type" so we would have the same config in web UI and phone UI

@yozmag
Copy link
Author

yozmag commented May 9, 2016

Yes, we have to add those, I missed that. Do you do that or I do the change?

@bmachens
Copy link
Collaborator

bmachens commented May 9, 2016

Feel free to do that. it's your PR

@yozmag
Copy link
Author

yozmag commented May 9, 2016

I have changed the PR. It all ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants