adaptive regularization added #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFBurg
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Very nice work @pollytur ! I made a few very small suggestions, mainly on naming consistency and structure consistency, most of them you could commit right within the PR (I used the suggest function). Sorry again this PR slipped through on my todo list and you needed to wait so long.
Co-authored-by: Max Burg <[email protected]>
Co-authored-by: Max Burg <[email protected]>
Co-authored-by: Polina Turishcheva <[email protected]>
MaxFBurg
requested changes
Jul 9, 2024
MaxFBurg
previously approved these changes
Jul 10, 2024
Co-authored-by: Max Burg <[email protected]>
|
@MaxFBurg I think you would need to reapprove after I committed the suggested change |
MaxFBurg
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to add adaptive regularisation for full gaussian readouts