Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix that cannot correctly set bn layer channels #210

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

wurining
Copy link
Contributor

When setting the hidden_channels as a integer, function add_bn_layer was passed a error parameter which caused TypeError as below

Traceback (most recent call last):
  File "/***/sensorium_2023/main.py", line 143, in <module>
    full_3d_model = make_video_model(
  File "/***/sensorium_2023/sensorium_2023/sensorium/models/make_model.py", line 141, in make_video_model
    core = Basic3dCore(**core_dict)
  File "/***/conda_envs/envs/sensorium/lib/python3.9/site-packages/neuralpredictors/layers/cores/conv3d.py", line 169, in __init__
    self.add_bn_layer(layer=layer, hidden_channels=hidden_channels[0])
TypeError: 'int' object is not subscriptable

@MaxFBurg MaxFBurg self-requested a review March 7, 2024 10:34
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 7.38%. Comparing base (a64a9cc) to head (d59eaab).

Files Patch % Lines
neuralpredictors/layers/cores/conv3d.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #210   +/-   ##
=====================================
  Coverage   7.38%   7.38%           
=====================================
  Files         58      58           
  Lines       5947    5947           
  Branches    1006    1006           
=====================================
  Hits         439     439           
  Misses      5478    5478           
  Partials      30      30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxFBurg MaxFBurg merged commit a71eb25 into sinzlab:main Mar 7, 2024
6 of 7 checks passed
@MaxFBurg
Copy link
Member

MaxFBurg commented Mar 7, 2024

Thank you very much for the example and fix @wurining - we highly appreciate your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants