Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scopePath on Windows #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix scopePath on Windows #75

wants to merge 1 commit into from

Conversation

mikkotikkanen
Copy link

On windows the provided path slashes are "" instead of "/"

On windows the provided slashes are "\" instead of "/"
@jstroem
Copy link
Contributor

jstroem commented Jan 16, 2014

Shouldn't this bug be fixed using: http://nodejs.org/api/path.html#path_path_sep

@mikkotikkanen
Copy link
Author

Well, it doesn't particularly matter. ""-slashes break the regexp regardless.

@pmoleri
Copy link

pmoleri commented Mar 9, 2016

I think the code shouldn't be using path at all, it's only using it to join dropbox paths instead of local paths.
I would use a simple string join: var scopePath = scope[0] === "/" ? scope : "/" + scope;

@CrackerakiUA
Copy link

why this is not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants