Update behaviour of shpc config get to only show value of key
#661
Conversation
Signed-off-by: Marco De La Pierre <[email protected]>
Signed-off-by: Marco De La Pierre <[email protected]>
|
and actually, note how I am now using |
shpc/client/config.py
Outdated
| @@ -47,8 +47,9 @@ def main(args, parser, extra, subparser): | |||
| elif command == "get": | |||
| for key in args.params: | |||
| value = cli.settings.get(key) | |||
| value = "is unset" if value is None else value | |||
| logger.info("%s %s" % (key.ljust(30), value)) | |||
| value = "Unset" if value is None else value | |||
There was a problem hiding this comment.
This looks good! Do you have preference for capitalized vs. not? I would expect all lowercase since it's not a sentence. Finally, could you bump the version and changelog?
There was a problem hiding this comment.
- updated string above to
unset - bumped version in
version.py - updated
CHANGELOG
|
Thank you @marcodelapierre ! Also this week I'm finally winding down from my turbo mode (second talk is recorded, fingers crossed it's acceptable and I don't need to do it again!) and then I can just go back into lizard programming mindset 24/7 (actually already did today!) flux-framework/flux-operator#208 Gosh sometimes you just need like 2 months mixed with too many papers and presentations to realize how amazing and wonderful programming is (and maybe I already knew that... 😆 ) |
|
I am glad you are almost back to your fav work routine!! I have this second week of leave before I start my new professional adventure..I am relaxing so well now, but also cannot wait to start!! |
Hi @vsoch , here we go, two minimal edits in this PR.
This addresses #658
Note how I have not added a flag to print both value and key, as I have noticed how
shpc view get <view>works, and realised that the new behaviour forshpc config get <key>actually exactly matches it, hence it is quite consistent.Two edits, one per commit:
is unsettoUnset, as I believe it is easier to handle (as a single string without spaces) in case the output is post-processed.Keen on your feedback as always!