Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo #262

Closed
wants to merge 9 commits into from
Closed

Logo #262

wants to merge 9 commits into from

Conversation

hritika2409
Copy link
Contributor

@hritika2409 hritika2409 commented Jun 2, 2024

Issue Title: LOGO FOR
WEBSITE
resolve issue: #81

Type of change ☑️

Added the 2 copies of the logo which i made with there appropriate names.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙️
Describe how have you verified the changes made.

-If u really like the changes please do merge it.I will be really very thankful and grateful to you

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ❌ Failed (Inspect) Jun 2, 2024 11:20am
draw-it-out-zbd1 ❌ Failed (Inspect) Jun 2, 2024 11:20am

@hritika2409 hritika2409 closed this Jun 2, 2024
@hritika2409 hritika2409 reopened this Jun 2, 2024
@singodiyashubham87
Copy link
Owner

@hritika2409 You have to put both these images under src/assets/images

@hritika2409
Copy link
Contributor Author

@singodiyashubham87 Added the 2 copies of the logo which i made with there appropriate names.

@singodiyashubham87
Copy link
Owner

@hritika2409 I know you have added the logo images but you have to add them in the images folder which is there under src/assets/images.

@hritika2409
Copy link
Contributor Author

@singodiyashubham87 done & i m really very sorry,as you have to explain alot in this process but thank you so much for your guidance.

@singodiyashubham87
Copy link
Owner

@hritika2409 Now you removed the curly brace from the CSS file which is causing an error in deployment, kindly fix it & I'll advise you to create a new fresh PR, we can't have more than 6 commits, Try to understand.

image

@hritika2409 hritika2409 closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants