Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brush strokes #151

Merged

Conversation

Harshitazz
Copy link
Contributor

@Harshitazz Harshitazz commented May 17, 2024

Issue Title: Add brush strokes

Add brush strokes: #60

Type of change ☑️

What sort of change have you made:

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • [x ] Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] This change requires a documentation update

Checklist: ☑️

  • [x ] My code follows the guidelines of this project.
  • [ x] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • x[ ] I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 7:41am
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 7:41am

@singodiyashubham87
Copy link
Owner

@Harshitazz Your PR has conflicts, Do resolve them.

@singodiyashubham87
Copy link
Owner

@Harshitazz It'll be better if you can just make the border rounded and change the color of the container from pure white to greyish type that matches the theme of the application.
image

@Harshitazz
Copy link
Contributor Author

sure

Copy link
Owner

@singodiyashubham87 singodiyashubham87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@singodiyashubham87
Copy link
Owner

@Harshitazz Kindly write meaningful commit messages, a commit message "push" doesn't really signifies anything.
image

@singodiyashubham87 singodiyashubham87 merged commit c4d78d6 into singodiyashubham87:main May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants