Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Internal function can_upgrade_soma_joinid_shape for experiment-level resize #3131

Closed
wants to merge 1 commit into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 4, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

Continues on #3125 #3127 #3130 underpinnings toward the goal of #2964 wherein we need:

  • Experiment-level upgrade/resize
  • Since there are multiple arrays in an experiment, a can-we-upgrade/resize-them-all pass

Note that upgrade_domain is the full-generality dataframe domain-upgrader, but, for experiment-level work we really need the plumbing that focuses on dataframe soma_joinid shape.

Notes for Reviewer:

This PR is a work in progress. It is not ready for review.

Base automatically changed from kerl/cpp-can-resizers-names to main October 4, 2024 16:41
@johnkerl johnkerl force-pushed the kerl/can_upgrade_soma_joinid_shape branch from 6cbda15 to 50054a1 Compare October 4, 2024 16:42
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (26b8929) to head (50054a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
+ Coverage   82.49%   82.60%   +0.11%     
==========================================
  Files          50       50              
  Lines        5204     5204              
==========================================
+ Hits         4293     4299       +6     
+ Misses        911      905       -6     
Flag Coverage Δ
python 82.60% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 82.60% <ø> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Oct 4, 2024

Will resubmit

@johnkerl johnkerl closed this Oct 4, 2024
@johnkerl
Copy link
Member Author

johnkerl commented Oct 4, 2024

Replaced by #3132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant