Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix deprecation warnings [release-1.14] #3013

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 18, 2024

Issue and/or context: #2998 was (it turns out) incomplete and did not fail until after 1.14.0 was tagged. :(

Fixes https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10912549693/job/30287424101#step:13:6876

See also #2999 [sc-53002]

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (7323987) to head (9335541).
Report is 1 commits behind head on release-1.14.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #3013      +/-   ##
================================================
+ Coverage         89.64%   89.79%   +0.14%     
================================================
  Files                40       40              
  Lines              4096     4096              
================================================
+ Hits               3672     3678       +6     
+ Misses              424      418       -6     
Flag Coverage Δ
python 89.79% <20.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <20.00%> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review September 18, 2024 00:33
@johnkerl johnkerl merged commit fc68247 into release-1.14 Sep 18, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/deprecation-fix branch September 18, 2024 12:13
@johnkerl johnkerl changed the title [python] Fix deprecation warnings [python] Fix deprecation warnings [release-1.14] Sep 18, 2024
@johnkerl johnkerl mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants