-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Support Python 3.12 #2108
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2108 +/- ##
===========================================
- Coverage 82.10% 71.77% -10.33%
===========================================
Files 87 101 +14
Lines 8112 6926 -1186
Branches 0 211 +211
===========================================
- Hits 6660 4971 -1689
- Misses 1452 1853 +401
- Partials 0 102 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Most strange. At
Yet when I run
I get no such error 🤔 |
See https://docs.python.org/3/whatsnew/3.12.html for information on why you may see this error. The default packages have changed in 3.12 for a virtual environment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than modifying _general_utilities.py, why not just add setuptools
to the list of dependencies for the package?
On python 3.7-3.11, it will already be installed and available, so little to no overhead. and it lets you keep the version code identical over all releases.
@bkmartinjr thanks for thinking of what I did not! I'll try that. However, I would also note Thoughts? |
Yep, just (actually) read the docs. What you did looks right to me - sorry for the noise! |
* [python] Probe Python 3.12 * more * google search * 3.7 too
* [python] Probe Python 3.12 * more * google search * 3.7 too Co-authored-by: John Kerl <[email protected]>
Issue and/or context: #1849
Changes:
Just a check to see what happens with 3.12.We did it! :)Notes for Reviewer:
This PR is not for review.CompletedStatus as of 2024-02-05:
numba
0.58 is not yet ready for Python 3.12.Status as of 2024-02-13:
numba
0.59 is installable on Python 3.12.