Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevented indentation when the TAB key is pressed on a hardware keyboard during IME input #2375

Closed
wants to merge 1 commit into from

Conversation

agata
Copy link
Contributor

@agata agata commented Nov 12, 2024

Description

During IME input, keyboard shortcuts should be disabled and processing should be delegated to the IME. Otherwise, shortcuts within the IME become disabled, and editor-side shortcuts, such as indentation, are executed even though input has not been finalized in the IME. This behavior does not occur in other native applications that use IME.

To retrieve the IME state, a property to obtain the IME input status has been added to RawEditorStateTextInputClientMixin, and its value is passed to EditorKeyboardShortcuts.

Steps to Reproduce:
Press the TAB key while inputting with IME.

Expected Behavior:
Moves within the IME candidate selection.

Current Behavior:
EditorKeyboardShortcuts is executed, and the indentation process is triggered.

Related Issues

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

@agata
Copy link
Contributor Author

agata commented Nov 13, 2024

I found an issue, so I will close this and resubmit it after making the necessary fixes.

@agata agata closed this Nov 13, 2024
@EchoEllet
Copy link
Collaborator

I found an issue,

Can you share the details of the issue when resubmitting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants