Prevented indentation when the TAB key is pressed on a hardware keyboard during IME input #2375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During IME input, keyboard shortcuts should be disabled and processing should be delegated to the IME. Otherwise, shortcuts within the IME become disabled, and editor-side shortcuts, such as indentation, are executed even though input has not been finalized in the IME. This behavior does not occur in other native applications that use IME.
To retrieve the IME state, a property to obtain the IME input status has been added to
RawEditorStateTextInputClientMixin
, and its value is passed toEditorKeyboardShortcuts
.Steps to Reproduce:
Press the TAB key while inputting with IME.
Expected Behavior:
Moves within the IME candidate selection.
Current Behavior:
EditorKeyboardShortcuts
is executed, and the indentation process is triggered.Related Issues
Type of Change