Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stripe.Refund object #66

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tsavko
Copy link

@tsavko tsavko commented Jun 17, 2020

Description of change

Add schema refunds.json for stripe.Refund object + add 'refunds' keys to STREAM_SDK_OBJECTS, STREAM_REPLICATION_KEY, STREAM_TO_TYPE_FILTER in init.py

Manual QA steps

  • Queried two years' worth of data from two different stripe environments

Risks

  • None

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @tsavko, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @tsavko!

Thank you for signing the Singer Contribution License Agreement.

@dyabmo
Copy link

dyabmo commented Jun 26, 2020

Hello, how could the merge request move forward ?
I need to use this feature.

nschairer added a commit to nschairer/tap-stripe that referenced this pull request Apr 12, 2022
@ilkkapeltola
Copy link

Can we please get this implemented?
Our business reporting critically requires this change. Doesn't look like a big thing to do either, and I'm quite baffled that after 2½ years such a simple PR hasn't been implemented on a major service like Stripe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants