Add missing If types for Is types
#961
Open
+348
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corresponding `If` types for ``IsNegative`, `IsInteger`, `IsFloat`, `IsEqual`, and the `Is` types for literal types have been missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the missing
Iftypes for the followingIstypes:IsNegativeIsIntegerIsFloatIsEqualIstypes for literal types insource/is-literal.d.tsI have followed the contributing guidelines. I also plan to review one of the open pull requests, as recommended.
Question:
I noticed typos in
source/is-integer.d.tson lines 6 and 11 (is a integerandis a intrger). Would you prefer a separate PR to address these, or should I include the fix in this one?Closes #788.