fix: support cloudflare workers #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing |
|
@sindresorhus fixed :) |
fregante
suggested changes
Feb 24, 2024
source/core/Ky.ts
Outdated
| this._options = { | ||
| // TODO: credentials can be removed when the spec change is implemented in all browsers. Context: https://www.chromestatus.com/feature/4539473312350208 | ||
| credentials: (this._input as Request).credentials || 'same-origin', | ||
| credentials: isCredentialsSupported ? ((this._input as Request).credentials || 'same-origin') : 'same-origin', |
There was a problem hiding this comment.
I don’t think this is gonna work, _options.credentials should not be set at all, according to the error.
Also the comment is very outdated and we can probably use:
Suggested change
| credentials: isCredentialsSupported ? ((this._input as Request).credentials || 'same-origin') : 'same-origin', | |
| credentials: isCredentialsSupported ? (this._input as Request).credentials : undefined, |
… as long as CloudFlare accepts {credentials: undefined} and doesn't actually require {}
by the way this would fix two duplicates:
|
Thanks @fregante i did update it. |
fregante
approved these changes
Feb 24, 2024
alecmev
added a commit
to alecmev/ky
that referenced
this pull request
Mar 21, 2024
sindresorhus#559 undid the fix in sindresorhus#543.
alecmev
added a commit
to alecmev/ky
that referenced
this pull request
Mar 21, 2024
sindresorhus#559 undid the fix in sindresorhus#543.
alecmev
added a commit
to alecmev/ky
that referenced
this pull request
Mar 22, 2024
sindresorhus#559 undid the fix in sindresorhus#543. Added `exactOptionalPropertyTypes` to `compilerOptions` to prevent this from happening again, seems pretty low-impact. It should be okay to pass `undefined` to `credentials` and other options, but this is an upstream problem (see `RequestInit` in `undici-types/fetch.d.ts`). The build was failing on TS 5.4 because there's a `priority` in `RequestInit` now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to fix the Cloudflare workers issue mentioned here with the solution:
#366 (comment)
Fixes #366