Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options.windowSelector #91

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Add options.windowSelector #91

merged 8 commits into from
Oct 14, 2024

Conversation

danikaze
Copy link
Contributor

@danikaze danikaze commented Oct 2, 2024

It provides an implementation for #90

It's a simple feature, but to handle every case it makes the code a bit complex.

  • Providing the filter (windowSelector) the decision of applying 1. accelerators and 2. showing devTools, needs to be delayed until the "final options" are provided, as now they can be customized for each window
  • The options used to open the devtools now it's a map, to allow different options for each window
  • If the new (optional) filter is not provided, everything keeps working as before

Also, this PR tries also to refactor and reuse code as much as possible (therefore the new utility functions)

index.d.ts Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
danikaze and others added 5 commits October 13, 2024 11:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sindresorhus sindresorhus merged commit 30796ef into sindresorhus:main Oct 14, 2024
2 checks passed
@sindresorhus
Copy link
Owner

Thanks :)

@danikaze
Copy link
Contributor Author

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants