-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/proxy setting #2162
base: main
Are you sure you want to change the base?
Feat/proxy setting #2162
Conversation
# Conflicts: # source/menu.ts
@yosheng I will add this to my fork that still supports Windows 7/8/8.1! |
I will be glad, this PR coluld help to your project too. 🥰 |
@yosheng Two things I noticed, first, you have a redundant trailing Second, this should be made into a regular .html file and put in //static, then loaded with a line like: See my commit where I fixed all this (as well as migrated my own preload script to typescript, and renamed yours to proxy-preload.ts), as well as added a few styling changes to the window that I think look good > Alex313031@3742bbf |
@Alex313031 I appreciate about your propose! I'am a electron newbee, those suggestions will help me to know how could make code clean. 🤩 |
@yosheng Looks good, I will include your styling in my fork. Also, you indented your .html better, I will do that too lol. Also, in case you were wondering, the Roboto font is to match up with the rest of Electron. Electron uses Roboto by default, and most of the Caprine UI is in that font. Also, |
@Alex313031 Thanks for your advice! 😎 |
I need Caprine could proxy by setting without system proxy setting, so I add proxy setting in Advance Setting menu
When I click proxy setting it will open a windows and show default setting.
After click Enable and enter proxy server and relaunch caprine. Enjoy it 😎