Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Dark Mode CSS #2155

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

mquevill
Copy link
Collaborator

@mquevill mquevill commented Mar 21, 2024

These CSS changes are no longer necessary. Most of them are not even selectors on the page any more. I tested these one at a time and couldn't see any changes visually and checked for the selectors too.

Fixes #2180.
Fixes #2194.

Comment on lines -168 to -170
.__fb-dark-mode {
--header-height: 0 !important;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the newest round of Facebook's redesign, this actually needs to be removed, otherwise the bottom of the page is partially off the screen (See the button on the bottom left being cut off below)
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I literally just reported the cut off thing as an issue for dark mode, nice to see the code update to fix it is already ready already!

@agret
Copy link

agret commented Jun 19, 2024

While you are updating darkmode CSS, when you have a chat that uses a Messenger theme the text box will be light too which makes your writing impossible to read. Can you make the input box always dark? This issue makes it very hard to message some people.

image

@devCKVargas
Copy link

While you are updating darkmode CSS, when you have a chat that uses a Messenger theme the text box will be light too which makes your writing impossible to read. Can you make the input box always dark? This issue makes it very hard to message some people.

image

Checkout #2196 for a temporary fix

@dxwil
Copy link

dxwil commented Aug 24, 2024

Any updates on this? Happens to me...

@mquevill mquevill merged commit 4e7e6f7 into sindresorhus:main Nov 27, 2024
5 checks passed
@mquevill mquevill deleted the RemoveUnnecessaryCSS branch November 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oversized root element causing scrolling of whole window Dark mode theme doesn't fit in window
5 participants