New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor gliffy conversion; separate conversion and file output #33

Merged

sindrel merged 3 commits into master from fix/refactor-conversion

Nov 24, 2023

Owner

sindrel commented Nov 24, 2023

These changes are only changes to the code structure, no functional changes.

File IO has been extracted from the main function ConvertExcalidrawToGliffy, and is now handled by the new wrapper function ConvertExcalidrawToGliffyFile.
This slims down the main function, and makes it easier to unit test.

sindrel added 3 commits

November 24, 2023 19:46


fix: Refactor gliffy conversion; separate conversion and file output

77a85ca


fix: Return errors rather than fail execution

d9a9647


fix: Rename test func TestConvertExcalidrawToGliffyFile

9e2ac7b

sindrel added the enhancement label

sindrel self-assigned this

sindrel merged commit d8594f6 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment