Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.2 support #180

Closed
wants to merge 1 commit into from
Closed

Conversation

jprosevear
Copy link
Contributor

No description provided.

@jprosevear jprosevear changed the title 7.2 support Rails 7.2 support Aug 11, 2024
@jprosevear
Copy link
Contributor Author

Initial attempt, but currently blocked because mongoid has no 7.2 support

@simukappu simukappu mentioned this pull request Aug 12, 2024
@jprosevear
Copy link
Contributor Author

mongodb/mongoid#5852

@jprosevear
Copy link
Contributor Author

mongodb/mongoid#5852

Still waiting on upstream merge.

@jprosevear
Copy link
Contributor Author

mongodb/mongoid#5852

Still waiting on upstream merge.

Merged; hopefully release shortly, otherwise I'll use github verison.

@simukappu
Copy link
Owner

Have you checked if all tests passed?

@jprosevear
Copy link
Contributor Author

Have you checked if all tests passed?

I have not, but the mongo changes look minimal. I will try it directly if there is no release soon

@jprosevear
Copy link
Contributor Author

Mongoid has bumped release numbers; waiting for gems

@jprosevear
Copy link
Contributor Author

@simukappu ok mongoid 8.1.6 is out; do you want to retrigger a rebuild for this and / or your development branch

@jprosevear
Copy link
Contributor Author

Building in my fork: https://github.com/codalio/activity_notification/actions/runs/10963455543/job/30444974349

simukappu added a commit that referenced this pull request Sep 22, 2024
@simukappu
Copy link
Owner

Added use with Rails 7.2 and published v2.3.2. Thank you for your contribution!

@simukappu simukappu closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants