fix serialize arguments for Rails 7.1+ #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprosevear
force-pushed
the
fix-serialize-options
branch
from
2605e57
to
d627333
Compare
jprosevear
commented
Jul 17, 2024
| @@ -45,7 +45,11 @@ class Notification < ::ActiveRecord::Base | |||
| belongs_to :notifier, polymorphic: true, optional: true | |||
|
|
|||
| # Serialize parameters Hash | |||
| serialize :parameters, Hash | |||
| if Rails.gem_version >= Gem::Version.new('7.1') | |||
| serialize :parameters, type: Hash, coder: YAML | |||
There was a problem hiding this comment.
Based on reading the rails code and some tests, I believe YAML is the right selection
|
LGTM |
simukappu
added a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #178:
Summary
Rails deprecated passing the type as a second argument and no longer defaults to YAML as the default serializer:
https://github.com/rails/rails/blob/77dfa65392e672ac83ced68cda37d5770c16ea6c/activerecord/CHANGELOG.md?plain=1#L1262
https://github.com/rails/rails/blob/77dfa65392e672ac83ced68cda37d5770c16ea6c/activerecord/CHANGELOG.md?plain=1#L1282
Other Information
I did not realize this until I did config.load_defaults 7.1 . It may work in non-engine scenarios (see related rails issue rails/rails#52336), but this solves it for 7.1 and the upcoming 7.2
#173 original PR