Bugfix: ##any allows a nullable namespace, ##other doesn't

simplesamlphp · Sep 3, 2024 · 0e27f52 · 0e27f52
1 parent 6756791
commit 0e27f52
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/ExtendableAttributesTrait.php b/src/ExtendableAttributesTrait.php
@@ -218,10 +218,10 @@ function (Attribute $attr) {
                 ),
             );
         } else {
-            // All attributes must be namespaced, ergo non-null
-            Assert::allNotNull($actual_namespaces);
-
             if ($namespace === NS::OTHER) {
+                // All attributes must be namespaced, ergo non-null
+                Assert::allNotNull($actual_namespaces);
+
                 // Must be any namespace other than the parent element
                 Assert::allNotSame($actual_namespaces, static::NS);
             } elseif ($namespace === NS::TARGET) {