Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert type hints on abstract container for now.
This is our only abstract class in the compat suite and we expect people to implement this. Adding a type hint breaks existing implementations. So it's not really good to do this in a patch release.
- Loading branch information
49c1830
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3.2.4 release actually started to throw this error:
PHP Fatal error: Declaration of SAML2\Compat\Ssp\Container::redirect($url, array $data = Array) must be compatible with SAML2\Compat\AbstractContainer::redirect($url, $data = Array) in /usr/share/nginx/html/vendor/simplesamlphp/saml2/src/SAML2/Compat/Ssp/Container.php on line 8
Thanks for patching it and releasing a quick fix. If container was modified as well it's likely there would have been no issues for us.