Skip to content

Commit

Permalink
Revert type hints on abstract container for now.
Browse files Browse the repository at this point in the history
This is our only abstract class in the compat suite and we expect
people to implement this. Adding a type hint breaks existing
implementations. So it's not really good to do this in a patch
release.
  • Loading branch information
thijskh committed Nov 16, 2018
1 parent 6c87014 commit 49c1830
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/SAML2/Compat/AbstractContainer.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ abstract public function debugMessage($message, $type);
* @param array $data
* @return void
*/
abstract public function redirect($url, array $data = []);
abstract public function redirect($url, $data = []);

/**
* Trigger the user to perform a POST to the given URL with the given data.
Expand All @@ -46,5 +46,5 @@ abstract public function redirect($url, array $data = []);
* @param array $data
* @return void
*/
abstract public function postRedirect($url, array $data = []);
abstract public function postRedirect($url, $data = []);
}

1 comment on commit 49c1830

@hparadiz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3.2.4 release actually started to throw this error:
PHP Fatal error: Declaration of SAML2\Compat\Ssp\Container::redirect($url, array $data = Array) must be compatible with SAML2\Compat\AbstractContainer::redirect($url, $data = Array) in /usr/share/nginx/html/vendor/simplesamlphp/saml2/src/SAML2/Compat/Ssp/Container.php on line 8

Thanks for patching it and releasing a quick fix. If container was modified as well it's likely there would have been no issues for us.

Please sign in to comment.