Fix app crashing when trying to replacing the last screen during navigation #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #11505: Fix app crashing when trying to replacing the last screen during navigation. |
simple-services
requested review from
a team and
siddh1004
and removed request for
a team
auto-merge was automatically disabled
November 22, 2023 03:40
Pull request was converted to draft
msasikanth
force-pushed
the
sm/22nov/fix-router-crash
branch
2 times, most recently
from
1085722 to
bf5d7d1
Compare
We are no longer using this continuation
…ng top in `Router` We don't have any flows that replace the current screen with same screen, so added a check that prevents replacing current key with same key. This is to prevent removing the last key when there is only one key left.
Since certain screen keys can contain potential PII, we are just including the analytics name in the error.
msasikanth
force-pushed
the
sm/22nov/fix-router-crash
branch
from
bf5d7d1 to
4ba7271
Compare
siddh1004
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/simpledotorg/story/11505/fix-app-crashing-when-trying-to-replacing-the-last-screen-during-navigation