Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support Microsoft.OData.Core >= 8.0 #937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Remo
Copy link

@Remo Remo commented Sep 25, 2024

This is an attempt to support Microsoft.OData.Core >= 8.0. Don't merge it, it's incomplete.

  • I dropped support for .net7.0, .netstandard 2.0 and .net48
  • I removed the sample projects from the solution, they don't compile yet.
  • Some unit tests are failing, but mostly because we get OData and not odata in the URI.

@GerkinDev
Copy link

Hey there, can I help somehow with this ?

@Remo
Copy link
Author

Remo commented Oct 14, 2024

@GerkinDev I can't speak for the maintainer, but I guess we would have to fix the examples and understand why some URLs now contain OData instead of odata. Other than that, I haven't seen any issues so far, but it would also not hurt if more people would test this branch a bit better.

@GerkinDev
Copy link

I've tried running it in my app directly, without success. But since the app is mid-size, it can totally be caused by something else. I'll dig deeper and try to come with some help if I can

@GerkinDev
Copy link

Hello, FYI I've managed to fully migrate my app to .net 8.0, and your fork works just fine :)

@Remo
Copy link
Author

Remo commented Oct 28, 2024

@robertmclaws since you seem to own this repo, what is your take on this? Would it be okay if we would remove backwards compatibility and make everything run on .net 8 only?

@ajtowf
Copy link

ajtowf commented Dec 17, 2024

This PR should be merged as-is, what's the hold up?

@Remo
Copy link
Author

Remo commented Dec 17, 2024

The examples are gone and some tests are failing. It would be good if this could be fixed.

@fretje fretje mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants