Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed creation of group by clause based on nullable properties #855

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed creation of group by clause based on nullable properties #855

wants to merge 3 commits into from

Conversation

maxbruecken
Copy link

This PR fixes creation of group by clause within $apply if some properties of destination type are nullable.

@maxbruecken maxbruecken changed the title Fix creation of group by clause based on nullable properties Fixed creation of group by clause based on nullable properties Feb 18, 2022
davidnmbond
davidnmbond approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@davidnmbond davidnmbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will re-run unit tests with this in place, then merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnmbond davidnmbond davidnmbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxbruecken @davidnmbond