Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple font styles #212

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add support for multiple font styles #212

wants to merge 1 commit into from

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 11, 2024 •
edited
Loading

Related to #222
Resolves #211

Get a preview build

Download it from: simple-icons-font-multi-styles.zip

Changes

  • This changed the default font style to the same aspect ratio as the icon. Users still can use the squared version with the SimpleIcons-Squared.[ext] font file
  • Re-organized the font file locations since we added a new style
  • Specify the font-style in the font SVG template

Web browser preview

Typeface preview

Before After

File tree

font
├── simple-icons.css
├── simple-icons.min.css
├── eot
│   ├── SimpleIcons-Regular.eot
│   └── SimpleIcons-Squared.eot
├── otf
│   ├── SimpleIcons-Regular.otf
│   └── SimpleIcons-Squared.otf
├── svg
│   ├── SimpleIcons-Regular.svg
│   └── SimpleIcons-Squared.svg
├── ttf
│   ├── SimpleIcons-Regular.ttf
│   └── SimpleIcons-Squared.ttf
├── woff
│   ├── SimpleIcons-Regular.woff
│   └── SimpleIcons-Squared.woff
└── woff2
    ├── SimpleIcons-Regular.woff2
    └── SimpleIcons-Squared.woff2

@LitoMore LitoMore force-pushed the aspect-ratio-viewbox branch 2 times, most recently from a873aae to 1d8c5e4 Compare December 28, 2024 14:34
@LitoMore LitoMore changed the title Use a viewbox with the same aspect ratio as the icon entity Add support for multiple font styles Dec 28, 2024
@LitoMore LitoMore marked this pull request as ready for review December 28, 2024 15:04
@LitoMore LitoMore requested a review from mondeja December 28, 2024 15:04
@LitoMore LitoMore added the enhancement New feature or request label Dec 28, 2024
@LitoMore LitoMore force-pushed the aspect-ratio-viewbox branch 4 times, most recently from 9d85bcd to a32ed69 Compare December 29, 2024 04:40
@LitoMore LitoMore force-pushed the aspect-ratio-viewbox branch from a32ed69 to 5827c9b Compare January 6, 2025 21:21
@mondeja
Copy link
Member

mondeja commented Jan 12, 2025

This seems like a breaking change to me. Can we prepare it for v15?

@LitoMore
Copy link
Member Author

This seems like a breaking change to me. Can we prepare it for v15?

Sure. Let's convert it to draft.

@LitoMore LitoMore marked this pull request as draft January 12, 2025 23:21
@LitoMore LitoMore added the breaking change Issues or pull requests that include a breaking change and scheduled for the next major release label Jan 12, 2025
@LitoMore LitoMore force-pushed the aspect-ratio-viewbox branch from 5827c9b to 9291e74 Compare January 12, 2025 23:26
@mondeja mondeja added this to the v15.0.0 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja Awaiting requested review from mondeja

Assignees
No one assigned
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release enhancement New feature or request
Projects
None yet
Milestone
v15.0.0
Development

Successfully merging this pull request may close these issues.

Use a viewbox with the same aspect ratio as the icon entity
2 participants
@LitoMore @mondeja