Adds support for custom pysmurf-controller docker service names #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely see @BrianJKoopman's frustration with the current setup so thanks for addressing this but can you describe what testing you've done before I approve? |
|
Ok, I moved the operations for starting / stopping the pysmurf-controllers to a separate function so that they could be called and tested outside of a full hammer. I also added the subcommand This has been tested on satp1. |
msilvafe
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting docker service names for pysmurf-controller dockers. This will enable us to change docker services from
ocs-pysmurf-s<slot>toocs-<instance-id>by specifying manually the service names to use in the sys-config.Related: https://github.com/simonsobs/ocs-deployment-configs/issues/126#issuecomment-2418366911