Fix resonator frequency spacing plot #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #445
The old code ran np.quantile on the list of frequencies, then sorted it, then took the diff.
The new code takes the diff of the list of frequences, which is already sorted in frequency band order, and runs np.quantile on that.
Note this isn't perfect, as it still treats the two separate RF transmission lines (bands 0--3 and bands 4--7) as one, but the one -2GHz spacing is cut out via use of np.quantile.
Tested in Princeton R+D testbed.
Before:
After:
