Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sodetlib version to metadata #437

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

jlashner
Copy link
Collaborator

This PR adds the sodetlib version tag to the common metadata dict.

Resolves #436.

@jlashner jlashner requested a review from kmharrington August 13, 2024 18:39
Copy link
Member

@kmharrington kmharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to run this through a docker system to make sure the version that get's added is useful? I've seen dockers do weird things

@jlashner
Copy link
Collaborator Author

I did check this in a jackhammer util and it seems to be what we want:

cryo@smurf-srv20-satp1:~$ jackhammer util
cryo@smurf-srv20-satp1:/usr/local/src/pysmurf$ python3
Python 3.8.10 (default, May 26 2023, 14:05:08)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sodetlib
sodetlib.__version__
>>> sodetlib.__version__
'0.5.2+21.geaa66cc'

But ya I know there were docker/versioning issues with pysmurf previously

@kmharrington
Copy link
Member

great!

@jlashner jlashner merged commit 52f8a47 into master Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sodetlib version to get_metadata
2 participants